-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for NFLOG options to ip6tables #921
Conversation
Codecov Report
@@ Coverage Diff @@
## master #921 +/- ##
=========================================
Coverage ? 81.11%
=========================================
Files ? 11
Lines ? 1657
Branches ? 0
=========================================
Hits ? 1344
Misses ? 313
Partials ? 0 Continue to review full report at Codecov.
|
Thank you @frh for submitting the PR. Could you please add unit tests to verify the changes. This is a sample pr https://github.com/puppetlabs/puppetlabs-firewall/pull/917/files#diff-c4e9ab14ac1cfe5af5148d4ae962a10a . Thanks again |
Thanks for the review. Is it okay with these newest commits? |
@sheenaajay Have you had a chance to look over the unit tests I added? Let me know if you'd want any changes to them. |
@frh Thanks for incorporating the comments. Much appreciated for your contribution. Taking a look now. |
No description provided.