Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for NFLOG options to ip6tables #921

Merged
merged 5 commits into from
Jun 19, 2020
Merged

Add support for NFLOG options to ip6tables #921

merged 5 commits into from
Jun 19, 2020

Conversation

frh
Copy link
Contributor

@frh frh commented May 19, 2020

No description provided.

@frh frh requested a review from a team as a code owner May 19, 2020 12:20
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@a6bd566). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #921   +/-   ##
=========================================
  Coverage          ?   81.11%           
=========================================
  Files             ?       11           
  Lines             ?     1657           
  Branches          ?        0           
=========================================
  Hits              ?     1344           
  Misses            ?      313           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6bd566...5b09769. Read the comment docs.

@sheenaajay
Copy link
Contributor

Thank you @frh for submitting the PR. Could you please add unit tests to verify the changes. This is a sample pr https://github.com/puppetlabs/puppetlabs-firewall/pull/917/files#diff-c4e9ab14ac1cfe5af5148d4ae962a10a . Thanks again

@frh
Copy link
Contributor Author

frh commented May 21, 2020

Thank you @frh for submitting the PR. Could you please add unit tests to verify the changes. This is a sample pr https://github.com/puppetlabs/puppetlabs-firewall/pull/917/files#diff-c4e9ab14ac1cfe5af5148d4ae962a10a . Thanks again

Thanks for the review. Is it okay with these newest commits?

@frh
Copy link
Contributor Author

frh commented Jun 19, 2020

@sheenaajay Have you had a chance to look over the unit tests I added? Let me know if you'd want any changes to them.

@sheenaajay
Copy link
Contributor

@frh Thanks for incorporating the comments. Much appreciated for your contribution. Taking a look now.

@sheenaajay sheenaajay merged commit 9c495f8 into puppetlabs:master Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants