Add Solaris 11 support. #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -136,7 +136,10 @@ | |||
| $config = '/etc/inet/ntp.conf' | |||
| $driftfile = '/var/ntp/ntp.drift' | |||
| $keys_file = '/etc/inet/ntp.keys' | |||
| $package_name = [ 'SUNWntpr', 'SUNWntpu' ] | |||
| $package_name = $operatingsystemrelease ? { | |||
There was a problem hiding this comment.
Could you use $::operatingsystemrelease here?
|
And add |
|
The only one I didn't do is https://github.com/puppetlabs/puppetlabs-ntp/blob/master/spec/classes/ntp_spec.rb#L253 because it doesn't matter if the operating system release is 5.10 or 5.11. |
This commit is a simple change to Class['ntp::params'] which adds a selector to the default Solaris data so that the proper package name is managed on Solaris 11. With out this small change Solaris 11 hosts will attempt to improperly install package names following the old Solaris 10 standard.
|
nvm. Added |
| else | ||
| packagename = 'ntp' |
There was a problem hiding this comment.
Why are we removing the default assumption that the package is called ntp?
|
See #184 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is a simple change to Class['ntp::params'] which adds a
selector to the default Solaris data so that the proper package name
is managed on Solaris 11.
With out this small change Solaris 11 hosts will attempt to improperly
install package names following the old Solaris 10 standard.