Update Solaris support for newer Facter #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -229,7 +229,7 @@ | |||
| $config = '/etc/inet/ntp.conf' | |||
| $driftfile = '/var/ntp/ntp.drift' | |||
| $keys_file = '/etc/inet/ntp.keys' | |||
| if $::operatingsystemrelease =~ /^(5\.10|10|10_u\d+)$/ | |||
| if $::kernelrelease =~ /^(5\.10|10|10_u\d+)$/ | |||
There was a problem hiding this comment.
By changing this to use the kernelrelease fact, I think we can clean up the conditional to only check for 5.10.
Due to a change in behavior between Facter 1.x and 2.x, the operatingsystemrelease fact is no longer a desireable determination of Solaris release. This work updates the module to use the kernelrelease fact in place of operatingsystemrelease as it does not change behavior and is likely a more accurate representation of the version of Solaris being tested.
bmjen
added a commit
that referenced
this pull request
Aug 5, 2015
Update Solaris support for newer Facter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a change in behavior between Facter 1.x and 2.x, the
operatingsystemrelease fact is no longer a desireable determination
of Solaris release. This work updates the module to use the
kernelrelease fact in place of operatingsystemrelease as it does not
change behavior and is likely a more accurate representation of the
version of Solaris being tested.