-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding catalog_inputs to the pg_repack scheme for PE 2019.8.0+ #54
Conversation
pe_databases::maintenance::pg_repack is a classthat may have no external impact to Forge modules. This module is declared in 0 of 576 indexed public
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to add this table to the existing catalogs tables cron job ?
@MartyEwings :: I can, but doing so will cause the catalogs repack to fail pre 2019.8. tail /var/log/puppetlabs/pe_databases_cron/catalogs_repack.log facter -p pe_server_version |
That table came in in 2019.8.2 so we will have to have a conditional that exempts it prior to this release as we have to support 2019.8.x There is a conditional nick points to as an example in the comments of the previous PR #47 that should do the job |
Ahh, I see now. Okay that makes more sense, I'll get that fixed up. 👍🏽 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
tested and is working on 2021.1 as well |
Adding catalog_inputs to the pg_repack scheme for PE 2019.8.0+.