Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding catalog_inputs to the pg_repack scheme for PE 2019.8.0+ #54

Merged
merged 4 commits into from
May 12, 2021

Conversation

coreymbe
Copy link
Contributor

@coreymbe coreymbe commented May 4, 2021

Adding catalog_inputs to the pg_repack scheme for PE 2019.8.0+.

@coreymbe coreymbe requested a review from a team May 4, 2021 18:40
@puppet-community-rangefinder
Copy link

pe_databases::maintenance::pg_repack is a class

that may have no external impact to Forge modules.

This module is declared in 0 of 576 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

Copy link
Contributor

@MartyEwings MartyEwings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to add this table to the existing catalogs tables cron job ?

@coreymbe
Copy link
Contributor Author

coreymbe commented May 4, 2021

@MartyEwings :: I can, but doing so will cause the catalogs repack to fail pre 2019.8.

tail /var/log/puppetlabs/pe_databases_cron/catalogs_repack.log
ERROR: pg_repack failed with error: ERROR: relation "catalog_inputs" does not exist

facter -p pe_server_version
2018.1.18

@MartyEwings
Copy link
Contributor

@MartyEwings :: I can, but doing so will cause the catalogs repack to fail pre 2019.8.

tail /var/log/puppetlabs/pe_databases_cron/catalogs_repack.log

That table came in in 2019.8.2 so we will have to have a conditional that exempts it prior to this release as we have to support 2019.8.x

There is a conditional nick points to as an example in the comments of the previous PR #47

that should do the job

@coreymbe
Copy link
Contributor Author

coreymbe commented May 5, 2021

Ahh, I see now. Okay that makes more sense, I'll get that fixed up. 👍🏽

Copy link
Contributor

@MartyEwings MartyEwings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@MartyEwings
Copy link
Contributor

tested and is working on 2021.1 as well

@MartyEwings MartyEwings merged commit 3c9ef36 into puppetlabs:main May 12, 2021
@jarretlavallee jarretlavallee changed the title Changes to pg_repack.pp and pg_repack_spec.rb per SUP-2405 Adding catalog_inputs to the pg_repack scheme for PE 2019.8.0+ Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants