Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(SUP-2571) Purge legacy cron jobs if present #97

Merged
merged 1 commit into from
Oct 6, 2021
Merged

(SUP-2571) Purge legacy cron jobs if present #97

merged 1 commit into from
Oct 6, 2021

Conversation

gavindidrichsen
Copy link

@gavindidrichsen gavindidrichsen commented Oct 4, 2021 •
edited
Loading

Add vacuum crons to the $legacy_crons array. Manually verified on a primary that it successfully removes any of the 'old' repack/vaccum cron jobs.

@CLAassistant
Copy link

CLAassistant commented Oct 4, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@MartyEwings MartyEwings added the bug label Oct 5, 2021
@gavindidrichsen gavindidrichsen marked this pull request as ready for review October 6, 2021 13:52
@gavindidrichsen gavindidrichsen requested a review from a team as a code owner October 6, 2021 13:52
MartyEwings
MartyEwings approved these changes Oct 6, 2021
View reviewed changes
Copy link
Contributor

@MartyEwings MartyEwings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, it does not seem to interfere with a system without legacy crons, I'm unable to test with them, @m0dular any concerns about the implementation? I'm inclined to merge

@gavindidrichsen gavindidrichsen changed the title Ensure pe_databases::pg_repack class also purges old vaccum cron jobs (SUP-2571) Purge legacy cron jobs if present Oct 6, 2021
jarretlavallee
jarretlavallee suggested changes Oct 6, 2021
View reviewed changes
Copy link
Contributor

@jarretlavallee jarretlavallee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, this looks good. I would usually have left it in the other class as that aligns with the existing style in this repo, but it is fine to move to a separate class. My only comments are on the name of the class and removing an internal link.

manifests/legacy/cron_remover.pp Outdated Show resolved Hide resolved
manifests/legacy/cron_remover.pp Outdated Show resolved Hide resolved
jarretlavallee
jarretlavallee approved these changes Oct 6, 2021
View reviewed changes
Copy link
Contributor

@jarretlavallee jarretlavallee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jarretlavallee jarretlavallee merged commit c99af79 into puppetlabs:main Oct 6, 2021
@gavindidrichsen gavindidrichsen deleted the gavindidrichsen/pr/remove_legacy_crons branch October 6, 2021 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartyEwings MartyEwings MartyEwings approved these changes

@jarretlavallee jarretlavallee jarretlavallee approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gavindidrichsen @CLAassistant @jarretlavallee @MartyEwings