Use (squashed) subtree, not submodule, to include pd-lib-builder #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'll add it back as a Git subtree soon, as recommended by pd-lib-builder's tips-and-tricks doc, https://github.com/pure-data/pd-lib-builder/blob/master/tips-tricks.md#keeping-pd-lib-builder-up-to-date
git-subtree-dir: pd-lib-builder git-subtree-split: e6cff66
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This is an alternative version of #6 using a squashed subtree.
The
pd-lib-buildertips-and-tricks document suggests that repositories should includepd-lib-builderby declaring it a git-subtree rather than a git-submodule.This PR does that: It removes the previous submodule-type of inclusion, and implements the subtree-type inclusion instead. In contrast to #6 which pulls in the full commit history of the subtree, this PR here squashes the history before inclusion.
Note: I don't actually suggest that using subtree is the way to go. At least for me it has been almost a decade since I last pondered the subtree-vs-submodule question. However, I think that the "helloworld" example linked from
pd-lib-builder's README should followbestannounced practices.