Update changelog since v2.0.2 #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHANGELOG.md
Outdated
|
|
||
| Bugfixes: | ||
|
|
||
| Other improvements: | ||
| - Updated `Record.Builder.merge` and `Record.Builder.union` to override existing fields (#73) |
There was a problem hiding this comment.
I think this change is breaking? @kl0tl could you clarify?
There was a problem hiding this comment.
This changes the behaviour of Record.Builder.merge and Record.Builder.union, so that
build (merge { x: 1, y: "y" }) { y: 2, z: true }has now type
{ x :: Int, y :: String, z :: Boolean }
-- instead of
{ x :: Int, y :: Int, z :: Boolean }
and
build (union { x: 1, y: "y" }) { y: 2, z: true }has now type
{ x :: Int, y :: String, y :: Int, z :: Boolean }
-- instead of
{ x :: Int, y :: Int, y :: String, z :: Boolean }
This is indeed a breaking change.
There was a problem hiding this comment.
I edited Cyril's comment above to make the differences easier to see.
@kl0tl What's a good way to summarize this change?
There was a problem hiding this comment.
What do you think of:
Updated
Record.Builder.mergeandRecord.Builder.unionso that they behave likeRecord.mergeandRecord.union: fields from the argument override those of the record being built in case of overlaps.
|
This looks good otherwise |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR updates the CHANGELOG in preparation for the upcoming release of this library.
Related: purescript/purescript#3985