Skip to content

Commit

Permalink
references modified and doi added
Browse files Browse the repository at this point in the history
Co-Authored-By: Adam R. Jensen <[email protected]>
  • Loading branch information
BernatNicolau and AdamRJensen committed Aug 26, 2024
1 parent 4281d61 commit 8b13595
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 6 deletions.
6 changes: 6 additions & 0 deletions docs/examples/irradiance-transposition/test_muneer.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
import pvlib

lat = 41.54
lon = 2.40
df = pvlib.iotools.get_pvgis_hourly(lat, lon, surface_tilt = 30, )

Check failure on line 5 in docs/examples/irradiance-transposition/test_muneer.py

View workflow job for this annotation

GitHub Actions / flake8-linter

E251 unexpected spaces around keyword / parameter equals

Check failure on line 5 in docs/examples/irradiance-transposition/test_muneer.py

View workflow job for this annotation

GitHub Actions / flake8-linter

E251 unexpected spaces around keyword / parameter equals
test

Check failure on line 6 in docs/examples/irradiance-transposition/test_muneer.py

View workflow job for this annotation

GitHub Actions / flake8-linter

F821 undefined name 'test'

Check failure on line 6 in docs/examples/irradiance-transposition/test_muneer.py

View workflow job for this annotation

GitHub Actions / flake8-linter

W292 no newline at end of file
14 changes: 8 additions & 6 deletions pvlib/irradiance.py
Original file line number Diff line number Diff line change
Expand Up @@ -1012,7 +1012,7 @@ def muneer(surface_tilt, dhi, b):
b : numeric
Radiance distribution index, introduced by Moon and Spencer [2]_ to model

Check failure on line 1013 in pvlib/irradiance.py

View workflow job for this annotation

GitHub Actions / flake8-linter

E501 line too long (81 > 79 characters)
luminance distribution of overcast sky. [unitless]
Recommend values from [X]_:
Recommend values from [1]_:
- isotropic: b = 0
- shaded surface: b = 5.73
Expand All @@ -1026,11 +1026,13 @@ def muneer(surface_tilt, dhi, b):
References
----------
.. [1] Muneer, T., 1990, Solar radiation model for Europe.
Building services engineering research and technology, 11: 153-163.
.. [2] Moon P and Spencer D E Illumination from a non-uniform sky
Trans. Illum. Eng. Soc. (London) 37 707-725 (1942)
.. [1] Muneer, T., 1990. Solar radiation model for Europe. Building
Services Engineering Research and Technology 11, 153-163.
:doi:`10.1177/014362449001100405`
.. [2] Moon, P., Spencer, D.E., 1942. Illumination from a non-uniform sky.
Trans. Illum. Eng. Soc. (London) 37, 707-725.
:doi:`10.1177/096032719302500301`
'''

term1 = 2 * b / (np.pi * (3 + 2 * b))
Expand Down

0 comments on commit 8b13595

Please sign in to comment.