-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardise variable name for clearsky GHI and DNI, add to glossary #2272
Comments
Except for just |
I prefer |
I think we're set on Would updating these variables be classed as breaking changes and require some kind of deprecation? I am thinking about #2237 |
Did you consider having just one PR for these two names since the changes are so closely related? |
@adriesse I asked about PR structure here but thought each variable had to be separate, no response so I was not really sure. I confess I think I underestimated the overlap. Is it possible to combine PRs after creation? We should do that if it would help with merging later. |
Sorry I didn't speak up earlier. I'm not the best person to advise on the PR machinations. :( |
Is your feature request related to a problem? Please describe.
I have counted three variations of clear sky GHI in the docs:
clearsky
(inclearsky.detect_clearsky
)clearsky_ghi
(inirradiance.clearsky_index
)ghi_clearsky
(inirradiance.dirindex
)and no entry in the variables and symbols page (soon to become a glossary #2234)
for DNI, we have
dni_clear
in the variables and symbols page but alsoclearsky_dni
(inirradiance.dni
) anddni_clearsky
(inirradiance.dirindex
) in the docs.Describe the solution you'd like
Additional context
Related: #1253
The text was updated successfully, but these errors were encountered: