-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add retrieval function for horizon profile from MINES Paris Tech #1295
base: main
Are you sure you want to change the base?
Conversation
I'm lovin' this! Could we also look into retrieving pvgis horizon data, how do they compare to the SRTM from MINES? |
MINES appears to have slightly changed their API, we need to skip one more row (to 26) |
Thank you @bgpierc! If you are already using it, I'd be happy to hear if you find it useful and how it may compare to other sources you are using. Within a month or so I'll return and hopefully finish this PR fyi. |
Thanks, I've implemented a similar function to pull from pvgis and one to calculate directly from a DEM in #1395, all three methods appear to line up well (within ~2 degrees MAE) with each other and field data I've taken, so it's looking good |
@YvesMSaintDrenan Are you ok with adding this function to pvlib? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The service is provided by MINES ParisTech though I cannot find any official documentation for it.
Nor can I. After quite some digging, all I could find is this: http://toolbox.1.webservice-energy.org/service/wps?SERVICE=WPS&Request=DescribeProcess&Identifier=compute_horizon_srtm&version=1.0.0
I'm reluctant to merge this PR without something satisfying in the References
section :/
Co-authored-by: Kevin Anderson <[email protected]>
Co-authored-by: Kevin Anderson <[email protected]>
The service has a notably better azimuthal resolution than PVGIS, but I agree that the missing documentation is a bummer. @YvesMSaintDrenan could you perhaps add a subpage to the SoDa Pro website or upload a short note describing the service somewhere? |
docs/sphinx/source/api.rst
for API changes.docs/sphinx/source/whatsnew
for all changes. Includes link to the GitHub Issue with:issue:`num`
or this Pull Request with:pull:`num`
. Includes contributor name and/or GitHub username (link with:ghuser:`user`
).The proposed function retrieves the local horizon profile for a specific location (latitude, longitude, and elevation). The returned horizon profile has a resolution of 1 degree in the azimuth direction. The service is provided by MINES ParisTech though I cannot find any official documentation for it.
The function added in this PR (
pvlib.iotools.get_mines_horizon
) is very similar to the function added in #1395 (pvlib.iotools.get_pvgis_horizon
).