Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Huld PV model #1940

Merged
merged 24 commits into from
Feb 8, 2024
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/sphinx/source/whatsnew/v0.10.4.rst
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ v0.10.4 (Anticipated March, 2024)

Enhancements
~~~~~~~~~~~~
* Added the Huld PV model (:pull:`1940`)
* Added the Huld PV model used by PVGIS (:pull:`1940`)


Bug fixes
Expand All @@ -30,3 +30,4 @@ Requirements
Contributors
~~~~~~~~~~~~
* Cliff Hansen (:ghuser:`cwhanse`)
* :ghuser:`matsuobasho`
4 changes: 4 additions & 0 deletions pvlib/pvarray.py
Original file line number Diff line number Diff line change
Expand Up @@ -296,6 +296,10 @@ def huld(effective_irradiance, temp_mod, pdc0, k=None, cell_type=None):
P_{dc} = G' P_{dc0} (1 + k'_1 \log(G') + k'_2 \log^2 (G') + k'_3 T' +
k'_4 T' \log(G') + k'_5 T' \log^2 (G') + k'_6 T'^2)


Users should be aware that at very low irradiance, i.e.,
:math:`G' < 20 W/m^2`, :math:`P_{dc}` may be negative.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:math:`G' < 20 W/m^2`, :math:`P_{dc}` may be negative.
:math:`G' < 20 W/m^2`, :math:`P_{dc}` may be negative.
This is caused by the :math:`\log(G')` term, which tends toward
negative infinity as irradiance approaches zero.

I can provide a reference that discusses this, if it is of interest.

cwhanse marked this conversation as resolved.
Show resolved Hide resolved

PVGIS documentation shows a table of default parameters :math:`k'` for
different cell types. The parameters :math:`k'` differ from the parameters
:math:`k` expected by :py:func:`huld` by the factor ``pdc0``, that is,
Expand Down
Loading