Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix parsing for CRLs with TLVs > 65535 bytes #7575

Merged
merged 3 commits into from
Sep 7, 2022
Merged

Conversation

reaperhulk
Copy link
Member

No description provided.

this tests CRLs larger than 65535 bytes in size. rust-asn1 supports up
to 4GiB TLVs now, but we'll avoid putting a test vector that big for now
@reaperhulk reaperhulk changed the title add CRL test vector with 10,000 revoked items fix parsing for CRLs with TLVs > 65535 bytes Sep 7, 2022
@alex alex enabled auto-merge (squash) September 7, 2022 11:40
@reaperhulk reaperhulk linked an issue Sep 7, 2022 that may be closed by this pull request
@alex alex merged commit d518a18 into pyca:main Sep 7, 2022
reaperhulk added a commit to reaperhulk/cryptography that referenced this pull request Sep 7, 2022
* add CRL test vector with 9,999 revoked items

* bump rust-asn1

* add large CRL test

this tests CRLs larger than 65535 bytes in size. rust-asn1 supports up
to 4GiB TLVs now, but we'll avoid putting a test vector that big for now
@reaperhulk reaperhulk deleted the big-crl branch September 7, 2022 12:00
alex pushed a commit that referenced this pull request Sep 7, 2022
* fix parsing for CRLs with TLVs > 65535 bytes (#7575)

* add CRL test vector with 9,999 revoked items

* bump rust-asn1

* add large CRL test

this tests CRLs larger than 65535 bytes in size. rust-asn1 supports up
to 4GiB TLVs now, but we'll avoid putting a test vector that big for now

* changelog and 38.0.1 bump
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

CRL is limited in size (3110) in cryptography 38
2 participants