Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT/BLD: Remove Cython as a runtime requirement #380

Merged

Conversation

bocklund
Copy link
Collaborator

@bocklund bocklund commented Oct 21, 2021

Cython is not a runtime requirement and can be removed. It should stay in pyproject.toml and requirements-dev.txt since it is required at build time.

Hopefully requirements-dev.txt can be removed after pypa/setuptools#2816 is complete and pip install -e . is PEP 517-compatible (i.e. PEP 660).

Checklist

  • If any dependencies have changed, the changes are reflected in the
    • setup.py (runtime requirements)
    • pyproject.toml (build requirements)
    • requirements-dev.txt (build and development requirements)

@codecov
Copy link

codecov bot commented Oct 21, 2021

Codecov Report

Merging #380 (ccb5230) into develop (77f25eb) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #380      +/-   ##
===========================================
- Coverage    89.93%   89.92%   -0.01%     
===========================================
  Files           44       44              
  Lines         4370     4368       -2     
===========================================
- Hits          3930     3928       -2     
  Misses         440      440              
Impacted Files Coverage Δ
pycalphad/plot/eqplot.py 68.88% <0.00%> (-0.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77f25eb...ccb5230. Read the comment docs.

@bocklund bocklund requested a review from richardotis October 22, 2021 20:32
@bocklund bocklund merged commit 62ad209 into pycalphad:develop Oct 22, 2021
@bocklund bocklund deleted the maint-bld-remove-Cython-runtime branch October 22, 2021 21:54
richardotis pushed a commit to richardotis/pycalphad that referenced this pull request Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants