Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for using unicode characters in update_config() #840

Merged
merged 2 commits into from
Aug 19, 2023
Merged

Support for using unicode characters in update_config() #840

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
babb647
Support for using unicode characters in update_config
LeoHsiao1 Apr 20, 2023
a6b71ee
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions jenkinsapi/job.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -627,7 +627,7 @@ def modify_scm_url(self, new_source_url, old_source_url=None):
def get_config_xml_url(self):
return "%s/config.xml" % self.baseurl

def update_config(self, config, full_response=False):
def update_config(self, config, full_response=False, encoding="utf-8"):
"""
Update the config.xml to the job
Also refresh the ElementTree object since the config has changed
Expand All @@ -637,7 +637,9 @@ def update_config(self, config, full_response=False):
"""
url = self.get_config_xml_url()
config = str(config) # cast unicode in case of Python 2
response = self.jenkins.requester.post_url(url, params={}, data=config)
response = self.jenkins.requester.post_url(
url, params={}, data=config.encode(encoding)
)
self._element_tree = ET.fromstring(config)

if full_response:
Expand Down