Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build.is_good() did not retrieve the build result, resulting in … #863

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: build.is_good() did not retrieve the build result, resulting in … #863

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions jenkinsapi/build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,9 +388,13 @@ def is_good(self) -> bool:
Return a bool, true if the build was good.
If the build is still running, return False.
"""
return (not self.is_running()) and self._data[
"result"
] == STATUS_SUCCESS
# return (not self.is_running()) and self._data[
# "result"
# ] == STATUS_SUCCESS
if self.is_running():
return False
self._data = self._poll()
return self._data["result"] == STATUS_SUCCESS

def block_until_complete(self, delay: int = 15) -> None:
count: int = 0
Expand Down
Loading