fix demois missing space #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graingert
commented
Dec 1, 2023
python/demo/main.py
Outdated
| @@ -14,7 +14,7 @@ def api_index() -> list[AnyComponent]: | |||
| # language=markdown | |||
| markdown = """\ | |||
| This site providers a demo of [FastUI](https://github.com/samuelcolvin/FastUI), the code for the demo\ | |||
There was a problem hiding this comment.
Maybe just removing the \ at the end here will fix it. I think with markdown one newline becomes a single whitespace you need two new lines for a br
There was a problem hiding this comment.
ye, you're right - just removing the \ fixes it.
Do you want to update your PR, or should I fix?
There was a problem hiding this comment.
I applied a suggestion to fix this
graingert
commented
Dec 1, 2023
graingert
commented
Dec 1, 2023
|
Thanks so much. First external PR 👏 👏 👏 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shows up as demois