Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Image component support #57

Merged
merged 5 commits into from
Dec 5, 2023
Merged

Add Image component support #57

merged 5 commits into from
Dec 5, 2023

Conversation

omarmhaimdat
Copy link
Contributor

@omarmhaimdat omarmhaimdat commented Dec 2, 2023 •
edited by samuelcolvin
Loading

fixes #53

@omarmhaimdat
Copy link
Contributor Author

The component has been tested and seems to work as expected, please let me know if there should be any changes/improvements/fixes:
Screenshot 2023-12-03 at 10 24 38

samuelcolvin
samuelcolvin approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, you have some conflicts.

@samuelcolvin samuelcolvin merged commit 90f30d2 into pydantic:main Dec 5, 2023
4 checks passed
@samuelcolvin
Copy link
Member

thanks so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelcolvin samuelcolvin Awaiting requested review from samuelcolvin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Image Component
2 participants
@omarmhaimdat @samuelcolvin