-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add video component #71
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #71 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 118 118
=========================================
Hits 118 118 |
490f407
to
e40da5c
Compare
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, thanks so much.
please rebase, resolve conflicts and make sure tests are passing - I suspect you'll need to do a bit of work to make sure the JSON Schemas match.
You also need to add video to the list of components in the demo index page.
By the way, please can you use fixes #54
in the PR body so the issue is automatically closed when the PR is merged, otherwise I'll forget. see here.
What's your opinion of the comments here #54 (comment) ? |
I think this looks great as a start, let's merge this once fixed and see what people think. |
1 similar comment
I think this looks great as a start, let's merge this once fixed and see what people think. |
thanks so much. |
fixes #54