Catch more errors when checking for sqlalchemy objects #854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kludex
approved these changes
Feb 11, 2025
Deploying logfire-docs with
|
| Latest commit: |
a2b17b2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ddd69e75.logfire-docs.pages.dev |
| Branch Preview URL: | https://alex-bad-getattr.logfire-docs.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://pydanticlogfire.slack.com/archives/C06EDRBSAH3/p1739205757483649
In general I think we need to start being more aggressive with catching exceptions here, we're working with arbitrary objects that may have all sorts of weirdness, and logging tracebacks about internal errors doesn't look good.