-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider setting a fixed minimum Rust version #1176
Comments
@arnaudsjs are you able to try building with latest Rust stable? (Rust 1.75.0 at present.) |
I tried building the package with Rust version |
I think this change in the rust compiler introduced in v1.74.0 (See also: RFC) is causing the issue. |
Hello, same issue with:
EDIT1: I'm looking for the most recent version that is compatible with rust 1.71.1 on AlmaLinux 8 and I will give the result here From what I've found, at the moment, Pydantic 2.5.3 + Pydantic-Core 2.14.6 are the latest versions working with Rust 1.71.1. |
What's the reason you need to build with older rust? |
Because neither AlmaLinux 8 nor AlmaLinux 9 has a newer version of Rust available in the official repositories. |
I think we should add an official minimum supported It would likely not be a breaking change so we should be able to ship this as a patch release. @arnaudsjs @locobastos would either of you be interested in helping create a PR to extend our rust support backwards and guarantee it? Also, do you know how frequently AlmaLinux updates available Rust version? It would be helpful to know how many versions we should consider lagging current stable by. |
It's not a big deal, it just means that building on RHEL8-like distro is limited to an older version of pydantic + pydantic-core.
|
This issue also persists with alpine Linux <= 3.19 as it uses Rust 1.72.1-r0. This breaks my builds of a python docker container for the ARMv6 Raspberry Pi platform. As said above, the last working version is Pydantic 2.5.3 + Pydantic-Core 2.14.6.
|
Red Hat is pretty slow to release packages because of their aim of the stability. Anyway, here is what I've found on the version history:
It seems they decrease the time between the release date and the availibility date, but I also know that they will release only versions they need. |
@davidhewitt, I will not have the time to help you. The only one thing I will do, is to try on an AlmaLinux 8 docker container as I'm doing today. I'm not sure I'll have a capital gains on this issue. @arnaudsjs already gave the command to reproduce this issue. |
Thanks @locobastos, that table is very helpful 👍 |
@davidhewitt I won't have the time to work on this. We are currently working around this issue by using the binary wheel instead. We were facing this issue on RockyLinux 8, which is like AlmaLinux, a binary-compatible derivative of RedHat Enterprise Linux. So the above-mentioned table should hold for both AlmaLinux, RockyLinux and RedHat Enterprise Linux. |
This is also happening on Alpine, for which no wheels are available. |
@BtbN I'm surprised you are finding there are no Alpine wheels, we do build for Can you run
|
We have a user needing 1.68 in #1202. To extend back that far we'd need to replace our |
Thanks @davidhewitt for pointing me to this issue. Is there a chance to catch that type of problem earlier, i.e. with some kind of an explicit dependency check before failing with an obscure compile error? |
Yes, there is a |
Rust 1.75.0 This Rust version allows us to build pydantic-core v2.16.3 / pydantic 2.6.4 |
👍 next |
Just a note. On an AlmaLinux 8.10 with Rust 1.75.0 + Cargo 1.75.0 + Python 3.11.7:
|
When I use the procedure in the README to build pydantic-core, the build fails. The issue can be reproduced in the following way:
It results in this output
Could someone provide me more insight into what is going wrong here?
System details:
The text was updated successfully, but these errors were encountered: