-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support Rust 1.70 as MSRV #1206
Conversation
2cc4aa0
to
63aad1a
Compare
CodSpeed Performance ReportMerging #1206 will degrade performances by 23.75%Comparing Summary
Benchmarks breakdown
|
please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, just left one question
@@ -24,6 +24,7 @@ include = [ | |||
"!tests/.pytest_cache", | |||
"!*.so", | |||
] | |||
rust-version = "1.70" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does setting this set the min version, or the required version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A minimum version, and at the moment all this will do is cause Cargo
to fail the build if the installed rust version is lower.
Future Rust versions might do more here (e.g. fail the build if we accidentally use stuff newer than this version).
Change Summary
This PR sets Rust 1.70 as the minimum supported version. To go lower, we would need to replace use of
OnceLock
with externalonce_cell::sync::OnceCell
both here and injiter
.I think going below 1.65 would be hard because we use both GATs and let-else from that release.
Related issue number
Related to #1176
Checklist
pydantic-core
(except for expected changes)Selected Reviewer: @samuelcolvin