fix: type-checking Eve dynamic attrs #1541
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding event hooks to an Eve instance produces types errors such as:
by pyright/pylance. The pyright maintainer's advice for such cases is to add a
__setattr__to such classes which allow dynamic attributes. Doing that here. Note it's behind thetyping.TYPE_CHECKINGguard which makes it have no effect at runtime, thus it only impacts type-checking. I've confirmed this fixes the type errors on pyright.Why care about
pyright?It's the more correct python type-checker (see official python typing benchmarks). Chances are other type-checkers (most importantly
mypy) may not fail on this temporarily only due to their lack of coverage.