Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Russian readme #3138

Merged
merged 28 commits into from
Nov 5, 2024
Merged

Add Russian readme #3138

merged 28 commits into from
Nov 5, 2024

Conversation

XORandom
Copy link
Contributor

@XORandom XORandom commented Oct 3, 2024

The Ru-version of the README, and links to ru.rst have also been added.

@XORandom XORandom requested a review from a team as a code owner October 3, 2024 10:45
@bilhox bilhox added this to the 2.5.2 milestone Oct 3, 2024
@yunline yunline added the docs label Oct 5, 2024
MyreMylar
MyreMylar approved these changes Oct 5, 2024
View reviewed changes
Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, LGTM 👍

Reverse translation via AI looks fine, other than that I will have to take it on trust as I'm not a native reader of Russian.

If anyone else in the community is, please add a review!

@Starbuck5 Starbuck5 removed this from the 2.5.2 milestone Oct 13, 2024
XORandom
XORandom commented Oct 14, 2024
View reviewed changes
docs/readmes/README.ja.rst
.. _繁體中文: README.zh-tw.rst
.. _Français: ./docs/readmes/README.fr.rst
.. _فارسی: ./docs/readmes/README.fa.rst
.. _Español: ./docs/readmes/README.es.rst
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"../docs/readmes" paths would not work in this file

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

XORandom
XORandom commented Oct 14, 2024
View reviewed changes
Copy link
Contributor Author

@XORandom XORandom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to remove unnecessary newlines

ankith26
ankith26 reviewed Nov 2, 2024
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed the modifications needed for the newly added italian README

@XORandom
Copy link
Contributor Author

XORandom commented Nov 4, 2024

Added the necessary links to the Italian README

ankith26
ankith26 approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to pygame-ce! 🥳

Approving this PR after a quick sanity check with google translate.

@ankith26
Copy link
Member

ankith26 commented Nov 5, 2024

Just added a minor commit fixing formatting to get this PR in

@ankith26 ankith26 merged commit 2fdcf73 into pygame-community:main Nov 5, 2024
2 checks passed
@ankith26 ankith26 added this to the 2.5.3 milestone Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankith26 ankith26 ankith26 approved these changes

@MyreMylar MyreMylar MyreMylar approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
2.5.3
Development

Successfully merging this pull request may close these issues.
6 participants
@XORandom @ankith26 @MyreMylar @yunline @Starbuck5 @bilhox