Include the explicit type in ColorLike
and RectLike
#3183
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the concrete classes to the
ColorLike
andRectLike
type unions.They are already implied by the other types, but should be added for clarity.
Since they are only type aliases to unions, their variable name is not always given, so what they represent might not be entirely obvious to users.
Bonus: Sort types in
ColorLike
by how often they are used.Example mypy error message, before:
After (much more clear!):
Note:
typing.py
now imports things from pygame. I don't think there is any risk of circular imports though.Note 2:
The
_<Shape>Like
type unions ingeometry.pyi
include their concrete classes already.