Port joystick and scrap to SDL3 #3208
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankith26
force-pushed
the
ankith26-more-sdl3-3
branch
from
2e19b25
to
e6149e8
Compare
Starbuck5
reviewed
Nov 3, 2024
ankith26
commented
Nov 3, 2024
| @@ -200,18 +210,53 @@ joy_get_guid(PyObject *self, PyObject *_null) | |||
| guid = SDL_JoystickGetGUID(joy); | |||
| } | |||
| else { | |||
| #if SDL_VERSION_ATLEAST(3, 0, 0) | |||
| guid = SDL_GetJoystickGUIDForID(pgJoystick_AsID(self)); | |||
There was a problem hiding this comment.
Something I didn't think about while making the PR: SDL_GetJoystickGUIDForID uses the instance ID and not the device ID returned by pgJoystick_AsID. This block needs more attention and thought
There was a problem hiding this comment.
In general the joystick port will need some more thought. They removed device indices completely, meaning we need to rework the initialization of joystick objects in general. There is no easy way to emulate this either (and we shouldn't anyway!).
With that said, you can use SDL_GetJoystickID to get the instance_id of an already open joystick.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports joystick and scrap to SDL3.
Porting scrap turned out to be surprisingly trivial, but it makes sense given that we are using like 3 functions of the SDL API, and the rest are custom implementations.
EDIT: There was some windows specific code that I initially missed when I made this comment, but that should hopefully be ported now as well.