Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise minimum supported SDL2 to 2.0.14 #3213

Merged
merged 1 commit into from
Nov 9, 2024
Merged

Raise minimum supported SDL2 to 2.0.14 #3213

merged 1 commit into from
Nov 9, 2024

Conversation

ankith26
Copy link
Member

@ankith26 ankith26 commented Nov 3, 2024

fixes #3210

@ankith26 ankith26 requested a review from a team as a code owner November 3, 2024 13:54
bilhox
bilhox approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@bilhox bilhox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

damusss
damusss approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@damusss damusss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure :)

Starbuck5
Starbuck5 approved these changes Nov 9, 2024
View reviewed changes
Copy link
Member

@Starbuck5 Starbuck5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really sure we need to remove the information from our docs, it's still useful information for people using old versions, just like old versionadded's and the like. But I'm not super against.

Thanks for the PR.

@ankith26
Copy link
Member Author

ankith26 commented Nov 9, 2024

I prefer the docs mentioning SDL as few times as possible, and I feel like bumping the minimum SDL version is a good time to clean up that info that probably benefits a super small fraction to begin with (and said fraction should ideally keep their distro version upto date anyways)

@ankith26 ankith26 added this to the 2.5.3 milestone Nov 9, 2024
@ankith26 ankith26 merged commit 6e24c38 into main Nov 9, 2024
25 checks passed
@ankith26 ankith26 deleted the ankith26-min-sdl2 branch November 9, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damusss damusss damusss approved these changes

@bilhox bilhox bilhox approved these changes

@Starbuck5 Starbuck5 Starbuck5 approved these changes

Assignees
No one assigned
Labels
dependencies SDL
Projects
None yet
Milestone
2.5.3
Development

Successfully merging this pull request may close these issues.

After dropping Python 3.8 we can go up to SDL 2.0.14
5 participants
@ankith26 @Starbuck5 @bilhox @damusss @yunline