Fix mouse events #14
Merged
Fix mouse events #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this good to go? Code changes seem OK to me. |
|
yeah, this is good as it is for now. It doesn't match the functionality of the website perfectly. But without knowing how they did it, makes it difficult to match. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
first issue in #11
the mouse even is explained in example
shadertoy_glsl_mouse_event.pyas well as some information in the comments on the source: https://www.shadertoy.com/view/Mss3zHthere is two issues with the current implementation when comparing the online reference with the local example:
the first frame when you click a white circle will show up. (in progress)a bit of a bodge where a click begins when you press the mouse button and ends when you move the mouse. This kind of resembles the behavior of the website when paused.