Build Windows wheels #191

naveen521kk · 2020-07-06T15:38:20Z

Fixes #19
This makes Travis build wheels and upload it to a draft Github Release. I tried downloading one that was built into my computer and it ran without any error for the example in ReadMe. This would for the installation of Pycairo for windows users who don't have C compilers.

Daltz333 · 2020-07-10T21:38:43Z

+1 to this.

EriKWDev · 2020-07-22T12:59:56Z

+1!

cqann · 2020-07-22T14:07:55Z

+1 👍

stuaxo · 2020-07-22T14:15:25Z

Thanks, for taking the time to put this together, having WHLs is a major help for Windows users.

naveen521kk · 2020-07-26T07:29:34Z

Any idea when will this be merged? Or maybe I should do any improvement or something?

stuaxo · 2020-07-26T14:01:24Z

I have a chunk of time tomorrow I can give this a try and give any feedback.

What's the best way to grab the WHLs, from Travis somehow?

Daltz333 · 2020-07-26T14:39:32Z

Ideally wouldn't you publish them to pypi? I assume Travis also has an artifact feature for publishing temporarily.

naveen521kk · 2020-07-26T15:18:31Z

For now, I have implemented it to put the whl's to a Draft Github Release. I think that is enough. Maybe if required I will implement it to upload it to PyPI directly. @stuaxo

EriKWDev · 2020-07-26T15:42:27Z

Having the wheels published to PyPi would solve all of my problems. I would then be able to have pycairo as a dependency without having to worry about my users having a C++ builder installed on their windows systems.... Currently, I have to resolve to the unofficial wheels on https://www.lfd.uci.edu/~gohlke/pythonlibs/#pycairo

stuaxo · 2020-07-26T16:03:54Z

Don't worry about publishing directly, I just want to have a quick poke at it... I've been a Cairo user on and off on Windows and Linux for a while so would like to give it a go. :)

naveen521kk · 2020-07-26T16:07:00Z

If you want to test it out you can visit this and download one for your system. I generated using this in my Fork.:)

setup.py

.travis.yml

lazka · 2020-07-26T16:18:52Z

.travis/downloadCairo.sh

@@ -0,0 +1,4 @@
+
+curl -L https://github.com/preshing/cairo-windows/releases/download/$CAIRO_VERSION/cairo-windows-$CAIRO_VERSION.zip -o cairocomplied.zip


This is an outdated cairo release :(

The only thing we can do now is to compile Cairo if we need the latest one. And btw the install script in cairo-windows is actually batch which Travis doesn't support :(

yeah. It's probably best to wait until https://gitlab.freedesktop.org/cairo/cairo/-/merge_requests/37 is merged and then build it ourselves using meson. But, yeah, let's not block this..

yeah. It's probably best to wait until https://gitlab.freedesktop.org/cairo/cairo/-/merge_requests/37 is merged and then build it ourselves using meson. But, yeah, let's not block this..

FYI: It's been merged.

Is the idea that we would use meson to do the builds here, or is there some buildfarm attached to freedesk that we get the builds from ?

OT (ish)
About a week ago, I had a chat with dependencies.io and they came up with a patch that uses their bot to generate PRs to update cairo + freedesktop, for preshing, cairo when upstream changes. This isn't so relevant if we don't use preshing cairo, but I guess we can still setup something to generate PRs here when upstream updates.

SO what should be done?

naveen521kk · 2020-07-27T07:26:02Z

Anything else should be done @lazka ?

stuaxo · 2020-07-27T08:40:19Z

I seem to recall, the older windows pycairo builds included cairo.dll named as _cairo.dll

Should this be the case for this WHL too?

naveen521kk · 2020-07-27T15:08:22Z

@stuaxo I tried renaming it so, but it failed, see screenshot below.

But this doesn't happen when it is the original state.

So, it should be cairo.dll and not _cairo.dll.
PS. I used the WHL from here which I generated using this script. :)

.travis.yml

naveen521kk · 2020-07-27T16:55:42Z

Anything else should be done @lazka ?

stuaxo · 2020-07-28T13:41:40Z

Hi
The upstream windows-cairo updated to CAIRO_VERSION to 1.17.2
preshing/cairo-windows#3

S

naveen521kk · 2020-07-28T13:48:12Z

Ok, then let me update. :)

stuaxo · 2020-07-28T14:51:31Z

Cheers, I should have linked the ticket before, but I had no idea @preshing would be so responsive :)

naveen521kk · 2020-08-01T05:57:55Z

I am curious does this work the same on other operating systems?

I tried the same in Google Colab(I don't have a Linux). But found it weird installing the wheel which generated using this script had no errors which running the examples. Idk whether this works on all systems.

naveen521kk · 2020-08-16T13:53:33Z

@stuaxo Done it. Any other thing to be done?

naveen521kk · 2020-08-17T18:10:53Z

Opps. I'm sorry if I'm late on this.
The maintainer, should set up a secret variable called GITHUBOAUTHTOKEN in Travis settings , a personal access token, with permission read:packages, repo, write:packages for GitHub release it is making.

stuaxo · 2020-08-18T22:13:38Z

Hi @naveen521kk
I'm putting patch to simplify your PR and move everything from your bash script into travis.yml and was wondering, is it intentional that the PR to add windows wheels removes this line -

- if [[ "$TRAVIS_OS_NAME" != "osx" ]] && [[ "$TRAVIS_PYTHON_VERSION" != "3.8" ]] && [[ "${TRAVIS_PYTHON_VERSION:0:4}" != "pypy" ]]; then python -m pip install --upgrade pygame; fi

?

EDIT: Is the reason that the PR is based on an older version of .travis.yml - the scripts: section looks a little different too ?

naveen521kk · 2020-08-19T03:05:47Z

Is the reason that the PR is based on an older version of .travis.yml

Yup that's why I left it so.

naveen521kk · 2020-08-19T04:22:27Z

I'm putting patch to simplify your PR and move everything from your bash script into travis.yml

It's neat to have a batch script for it instead of having all in Travis.yml and would also be easy to maintain. :)

stuaxo · 2020-08-19T13:57:22Z

It's neat to have a batch script for it instead of having all in Travis.yml and would also be easy to maintain. :)
This may be handy, I looked at various travis runners, in the end I paste everything in 'install' and 'script' to a shell script, remove the - and use it.
Adding something like this can go in a different PR.

Ideally we should make each PR should add just one thing, with minimal changes (and of course passing tests).
In that vein there may be a few PRs in this, we can split out - the obvious two are building windows WHLs and deployment.

Windows WHLs:

This is good work you've done getting all this all up and running, in some ways I made it a little dumber moving it to .travis.yml, I hope you don't mind.

I made a PR to port your script to plain .travis.yml naveen521kk#1 which has a few advantages -

We no longer duplicate the content of travis.yml in runPycairo.sh and have removed all the != 'windows' lines in the script section.
Travis is now in charge of building everything (runPycairo.sh had to build twice - 32 and 64 bit)

Everything else is the same as the script, just moved into travis.yml some minor changes:

Added the newer tests from more pycairo
Downloads are grouped with downloads from other platforms (in theory we could fail early here if they fail)
Files are downloaded to another folder (coverage was trying to check the python installation!)

TODO

Adding the new tests, came with a drawback though ... test_typing fails ! - We need to work out why that is and if needs fixing.
I don't have super amounts of free time, so this needs some testing before applying.

Deployment

This needs to be a different PR, we can see all tests passing before setting this up.

Meson

You started looking at building with meson, this is great + can go in a different PR

naveen521kk · 2020-08-19T15:10:26Z

You started looking at building with meson, this is great + can go in a different PR

I really couldn't go much about it. Any help is appreciated.

stuaxo · 2020-08-19T18:12:52Z

I don't think that's a big deal if we can't get meson working, for this.

naveen521kk · 2020-08-30T06:43:12Z

Adding the new tests, came with a drawback though ... test_typing fails ! - We need to work out why that is and if needs fixing.

Yes, now the upstream repo has a release with tee surface. And all test pass.

Also, I prefer GitHub Action over Travis(because powershell is lot familiar to me than bash). If you allow me @lazka can I use it.

stuaxo · 2020-08-30T12:06:41Z

Thanks :)

This can be two parts.

I'll check the WHL stuff later when in from of a computer + hopefully squash and merge to here.

I'm the meantime feel free to open a seperate ticket to discuss github actions.

stuaxo · 2020-08-31T11:01:04Z

Since all tests are passing, I squashed and merged this, from the PR where with the bits and pieces we worked on to get it all into .travis.yml.

Thanks for all the work to get this into shape.

naveen521kk · 2020-08-31T11:19:26Z

So @stuaxo when will we get wheels in pip?

stuaxo · 2020-08-31T13:21:58Z

I don't have access to that, we will see if @lazka appears :)

If I want to try this on my own branch should I just creating a release ?

I tried this, creating a new tag, but it only has the source files in it, not the WHLs - is my setup missing something?

naveen521kk · 2020-08-31T13:26:42Z

Maybe I will contact @lazka on gitter and see. Also, I can see you as a maintainer in PyPI. Looks like release should have appeared as a draft for @lazka maybe. And he should have configured the tokens.

stuaxo · 2020-08-31T17:27:54Z

I either missed being a maintainer earlier or it changed.
I'm starting to think 'attention to detail' may not be accurate when I wrote it on my C.v. :D

Even if I could release I would still double check. This is either my first commit on pycairo or first in years, so I did double check it was all good first.

If I can generate WHLs that I can download + then try them in a Windows VM then I'm happy to ask if we can pull the trigger, OTOH sounds like you already are.

I'm probably over cautious as last place I worked was a huge corporation where we tried double hard not to break stuff, so hope I'm not slowing stuff down too much :)

I'm definitely interested in the direction it goes, github actions look promising for instance.

naveen521kk · 2020-08-31T17:36:47Z

If I can generate WHLs that I can download + then try them in a Windows VM then I'm happy

@stuaxo You can download the artifact here and check yourself. I have checked for my part on x64 and x86 and certify it works( Based of example in readme and tee surface test, so don't blame me). If you want or @lazka I will make an PR of that script of GitHub Action I made.( Maybe tomorrow). Just saying I need it on PyPi as soon as possible.

stuaxo · 2020-09-01T09:49:17Z

Is it OK to rebase (or just recreate this branch), based off the pygobject/pycairo ?

This make the histories consistent (imagine if I broke something when I squashed the previous commits) - it's also a good chance to squash or get rid of the commits like "another try"*.

*I write a lot of these in my own branches :)

naveen521kk · 2020-09-01T10:00:02Z

I will do this in a new PR. You talking about actions right?

stuaxo · 2020-09-01T10:06:27Z

Yep, what's currently the msys_actions branch.

naveen521kk · 2020-09-01T10:08:00Z

I will make a new PR in some 10 min.

lazka · 2020-10-05T17:28:53Z

I've made a new release with those wheels now

naveen521kk added 2 commits July 6, 2020 20:31

Add Travis For Windows Wheels

1f58ede

Add regex for specific branch

944880b

naveen521kk mentioned this pull request Jul 14, 2020

Move to Poetry ManimCommunity/manim#165

Merged

1 task

lazka reviewed Jul 26, 2020

View reviewed changes

setup.py Outdated Show resolved Hide resolved

lazka reviewed Jul 26, 2020

View reviewed changes

.travis.yml Outdated Show resolved Hide resolved

lazka reviewed Jul 26, 2020

View reviewed changes

naveen521kk added 2 commits July 26, 2020 23:01

Don't duplicate setup.py

fa01da4

Remove stale variables

47bbd4b

lazka reviewed Jul 27, 2020

View reviewed changes

.travis.yml Outdated Show resolved Hide resolved

Remove Branch specific changes

d5865ff

Bump version of Cairo

76be61d

Remove Cache and before_cache as not required

024b296

naveen521kk mentioned this pull request Aug 27, 2020

Use Github Actions to Build preshing/cairo-windows#11

Closed

stuaxo closed this Aug 31, 2020

naveen521kk deleted the windows-wheels branch August 31, 2020 11:28

naveen521kk mentioned this pull request Aug 31, 2020

Provide Windows Wheels #19

Closed

naveen521kk mentioned this pull request Sep 1, 2020

Use Github Actions for building Wheels and not Travis #197

Merged

naveen521kk mentioned this pull request Sep 22, 2020

Create wheels Kozea/cairocffi#141

Closed

This was referenced Oct 6, 2020

docs: pycairo now has wheels on PyPi ManimCommunity/manim#517

Merged

Remove pycairo install docs 3b1b/manim#1255

Closed

		@@ -0,0 +1,4 @@

		curl -L https://github.com/preshing/cairo-windows/releases/download/$CAIRO_VERSION/cairo-windows-$CAIRO_VERSION.zip -o cairocomplied.zip

Build Windows wheels #191

Build Windows wheels #191

Conversation

naveen521kk commented Jul 6, 2020

Daltz333 commented Jul 10, 2020

EriKWDev commented Jul 22, 2020

cqann commented Jul 22, 2020

stuaxo commented Jul 22, 2020

naveen521kk commented Jul 26, 2020

stuaxo commented Jul 26, 2020

Daltz333 commented Jul 26, 2020

naveen521kk commented Jul 26, 2020 • edited Loading

EriKWDev commented Jul 26, 2020

stuaxo commented Jul 26, 2020

naveen521kk commented Jul 26, 2020

lazka Jul 26, 2020

Choose a reason for hiding this comment

naveen521kk Jul 26, 2020

Choose a reason for hiding this comment

lazka Jul 26, 2020

Choose a reason for hiding this comment

EriKWDev Aug 3, 2020

Choose a reason for hiding this comment

stuaxo Aug 6, 2020

Choose a reason for hiding this comment

naveen521kk Aug 8, 2020

Choose a reason for hiding this comment

naveen521kk commented Jul 27, 2020

stuaxo commented Jul 27, 2020

naveen521kk commented Jul 27, 2020

naveen521kk commented Jul 27, 2020

stuaxo commented Jul 28, 2020

naveen521kk commented Jul 28, 2020

stuaxo commented Jul 28, 2020

naveen521kk commented Aug 1, 2020 • edited Loading

naveen521kk commented Aug 16, 2020

naveen521kk commented Aug 17, 2020 • edited Loading

stuaxo commented Aug 18, 2020 • edited Loading

naveen521kk commented Aug 19, 2020

naveen521kk commented Aug 19, 2020

stuaxo commented Aug 19, 2020

naveen521kk commented Aug 19, 2020

stuaxo commented Aug 19, 2020

naveen521kk commented Aug 30, 2020

stuaxo commented Aug 30, 2020

stuaxo commented Aug 31, 2020

naveen521kk commented Aug 31, 2020

stuaxo commented Aug 31, 2020

naveen521kk commented Aug 31, 2020 • edited Loading

stuaxo commented Aug 31, 2020

naveen521kk commented Aug 31, 2020

stuaxo commented Sep 1, 2020

naveen521kk commented Sep 1, 2020

stuaxo commented Sep 1, 2020

naveen521kk commented Sep 1, 2020

lazka commented Oct 5, 2020

naveen521kk commented Jul 26, 2020 •

edited

Loading

naveen521kk commented Aug 1, 2020 •

edited

Loading

naveen521kk commented Aug 17, 2020 •

edited

Loading

stuaxo commented Aug 18, 2020 •

edited

Loading

naveen521kk commented Aug 31, 2020 •

edited

Loading