Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add typing to Name._infer and AssignName.infer_lhs #1651

Merged
merged 4 commits into from
Jun 22, 2022
Merged

Add typing to Name._infer and AssignName.infer_lhs #1651

merged 4 commits into from
Jun 22, 2022

Conversation

DanielNoord
Copy link
Collaborator

Steps

  • Write a good description on what the PR does.

Description

Doing one at a time...

Type of Changes

Type
✓ 🔨 Refactoring

Related Issue

@DanielNoord DanielNoord added the Maintenance Discussion or action around maintaining astroid or the dev workflow label Jun 21, 2022
@DanielNoord DanielNoord requested a review from cdce8p June 21, 2022 19:38
cdce8p
cdce8p requested changes Jun 21, 2022
View reviewed changes
astroid/bases.py Outdated Show resolved Hide resolved
astroid/inference.py Show resolved Hide resolved
astroid/inference.py Outdated Show resolved Hide resolved
astroid/nodes/node_classes.py Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Jun 21, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2541235797

  • 9 of 9 (100.0%) changed or added relevant lines in 2 files are covered.
  • 51 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.005%) to 92.271%
Files with Coverage Reduction New Missed Lines %
astroid/rebuilder.py 14 96.91%
astroid/protocols.py 37 91.51%
Totals Coverage Status
Change from base Build 2537372366: 0.005%
Covered Lines: 9407
Relevant Lines: 10195
💛 - Coveralls

@cdce8p cdce8p merged commit db6509b into pylint-dev:main Jun 22, 2022
@DanielNoord DanielNoord deleted the typing-inference branch June 22, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdce8p cdce8p cdce8p approved these changes

Assignees
No one assigned
Labels
Maintenance Discussion or action around maintaining astroid or the dev workflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DanielNoord @coveralls @cdce8p