-
-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix six with metaclass #893
Merged
Pierre-Sassoulas
merged 2 commits into
pylint-dev:master
from
hippo91:fix_six_with_metaclass
Feb 12, 2021
Merged
Fix six with metaclass #893
Pierre-Sassoulas
merged 2 commits into
pylint-dev:master
from
hippo91:fix_six_with_metaclass
Feb 12, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e unused-import due to the fact that six.with_metaclass is not consumed. Adds a unittest to check that bases attribute holds a call node and that ancestors attributes returns the correct class hierarchy.
@fmigneault are you ok with this change? |
Pierre-Sassoulas
approved these changes
Feb 11, 2021
jacobtylerwalls
added a commit
to jacobtylerwalls/astroid
that referenced
this pull request
Jun 15, 2022
… from six.with_metaclass()
jacobtylerwalls
added a commit
to jacobtylerwalls/astroid
that referenced
this pull request
Jun 15, 2022
… from six.with_metaclass()
jacobtylerwalls
added a commit
to jacobtylerwalls/astroid
that referenced
this pull request
Jun 15, 2022
… from six.with_metaclass()
jacobtylerwalls
added a commit
to jacobtylerwalls/astroid
that referenced
this pull request
Jun 15, 2022
… from six.with_metaclass()
2 tasks
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Jun 23, 2022
…with_metaclass() (#1622)
adam-grant-hendry
pushed a commit
to adam-grant-hendry/astroid
that referenced
this pull request
Jun 23, 2022
… from six.with_metaclass() (pylint-dev#1622)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps
Description
This PR corrects the brain dealing with
six.with_metaclass
.The error came from the tweaking of the node bases. It has not to be done.
For example, following code:
gives:
The base is a CallNode, whereas the ancestors are ClassDef from the class hierarchy.
Thus in the
six.with_metaclass
case, the base has to be a call node.Doing this, the
six
module is seen as really used and this avoids the emission ofunused-import
message.This PR should correct the failing CI on
pylint
side.Type of Changes
Related Issue
Failing CI on
pylint
.