Remove xfail marker from passing tests #994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test_augassign_recursion has been passing for a while. The remaining tests were fixed by context.path changes in 15e1921.
cdce8p
approved these changes
May 19, 2021
There was a problem hiding this comment.
LGTM! I was just wondering why the last one that is marked with Relaying on path copy is still failing. Haven't looked at it in detail though.
https://github.com/PyCQA/astroid/blob/01f9e2439513a83899b88b1053ca90f81ab49903/tests/unittest_inference.py#L5110-L5123
I'm not 100% sure, but I'd say that it relied on the changes in aea774e that were later reverted due to performance issues. |
Thanks for looking into it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps
For new features or bug fixes, add a ChangeLog entry describing what your PR does.Description
test_augassign_recursionhas been passing for a while. The remainingtests were fixed by
context.pathchanges in 15e1921.Type of Changes
Related Issue
N/A