Skip to content

Commit

Permalink
Add a mention of the score change for JSON in the Changelog
Browse files Browse the repository at this point in the history
This is a fix but I wonder... This looks like the fabled bug that will
break countless integration by being fixed. `--score=y` is the default setting,
and json is probably a prime candidate for automation. Is it reasonable to fix
it and ask everyone to change their option to `-s n`? I'm pretty sure no one
read the pylint's changelog.
  • Loading branch information
Pierre-Sassoulas committed Apr 26, 2020
1 parent 05329a4 commit c302d8b
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 0 deletions.
6 changes: 6 additions & 0 deletions ChangeLog
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,12 @@ Release date: TBA
Close #1482
Close #1553

* Fix the score option not being honored when exporting to JSON

The default setting was to have a score, but it did not work. Now it will give a score at the end of the json:

Close #3504

What's New in Pylint 2.4.4?
===========================
Release date: 2019-11-13
Expand Down
5 changes: 5 additions & 0 deletions doc/whatsnew/2.5.rst
Original file line number Diff line number Diff line change
Expand Up @@ -92,3 +92,8 @@ Other Changes
This command lists all extensions present in ``pylint.extensions``.

* Various false positives have been fixed which you can read more about in the Changelog files.

* The score option for JSON export has been fixed

The default setting is to have a score, but it did not work before. If a score appeared in your json, and you want to
go back what you had before, you must change the score option to "--score=n"

0 comments on commit c302d8b

Please sign in to comment.