Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling checker enhancement follow-up following #6137 #6416

Open
3 tasks
Pierre-Sassoulas opened this issue Apr 20, 2022 · 1 comment
Open
3 tasks

Spelling checker enhancement follow-up following #6137 #6416

Pierre-Sassoulas opened this issue Apr 20, 2022 · 1 comment
Labels
Enhancement ✨ Improvement to a component Minor 💅 Polishing pylint is always nice Needs PR This issue is accepted, sufficiently specified and now needs an implementation

Comments

@Pierre-Sassoulas
Copy link
Member

Pierre-Sassoulas commented Apr 20, 2022

Current problem

The spelling checker do not have end lineno or end column because we do not use a node. Also we're spell checking our own messages.

Desired solution

In the spelling checker, after we merge #5929 we should:

  • Pass node instead of line number as int in add_message
  • Add pylint's msgids and symbols to the dictionary automatically
  • Add python's builtin to the dictionary automatically (str, int, etc.)

Additional context

#6137 (comment)

@Pierre-Sassoulas Pierre-Sassoulas added Enhancement ✨ Improvement to a component Minor 💅 Polishing pylint is always nice labels Apr 20, 2022
@Pierre-Sassoulas Pierre-Sassoulas added the Needs PR This issue is accepted, sufficiently specified and now needs an implementation label Jul 14, 2022
@Pierre-Sassoulas
Copy link
Member Author

#4320 should be considered at the same time than pylint msgid/symbol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement ✨ Improvement to a component Minor 💅 Polishing pylint is always nice Needs PR This issue is accepted, sufficiently specified and now needs an implementation
Projects
None yet
Development

No branches or pull requests

1 participant