spellcheck will skip the rule names of mypy inline directives

[ejfine]

Type of Changes

	Type
✓	🐛 Bug fix

Description

The spellchecker was a bit overaggressive in flagging the Mypy rule names inside of ignore directives. This allows those to be ignored by the spellchecker.

[ejfine]

@Pierre-Sassoulas - you were the one who took a look at my previous PR regarding the spellchecker (#4330), are you still the right person to review this?

[coveralls]

Pull Request Test Coverage Report for Build 2278156268

• 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.002%) to 95.289%

---

Totals
Change from base Build 2277828137:	0.002%
Covered Lines:	15959
Relevant Lines:	16748

---

💛 - Coveralls

[Pierre-Sassoulas]

Sorry for the time it took to review. It looks pretty good already. I wanted to ask you to add a functional tests but I'm struggling to add one myself in #6137. I'll upgrade your own MR when I figure out how to do that.

[DanielNoord]

@eli88fine Sorry for letting this rest so long. I think @Pierre-Sassoulas and I agreed that this shouldn't be blocked by our internal changes to how we test the spelling checker.

That said, would you be willing to explore whether this regex matching can be done in the same pattern as above? regex matching and compiling is often quite expensive (it is on of our main costs during start-up) so I'd like to integrate most patterns where possible.
If not, please let me know and I might have some time to tinker with this myself!

[ejfine]

@DanielNoord - what's the "in the same pattern as above" that you're referring to? I don't see a link

[DanielNoord]

Let's get this merged 😄

[ejfine]

trying to follow the timestamps on all the different threads. Are you saying "leave the code alone, just add an entry in the doc/whatsnew" ?

Or are there actual code changes you think would be good?

[DanielNoord]

trying to follow the timestamps on all the different threads. Are you saying "leave the code alone, just add an entry in the doc/whatsnew" ?

Or are there actual code changes you think would be good?

Sorry! Being indecisive today 😅

The last comments were all recent. So let's change the pattern slightly and add the changelog entry!

[ejfine]

regex has been changed and docs updated

[DanielNoord]

One final change and then LGTM!

[Pierre-Sassoulas]

Thank you for your contribution @eli88fine ! It's going to be released in 2.14.