Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Primer can break unexpectedly on main because we use bleeding edge of repositories #8998

Open
DanielNoord opened this issue Sep 4, 2023 · 4 comments
Open

Primer can break unexpectedly on main because we use bleeding edge of repositories #8998

DanielNoord opened this issue Sep 4, 2023 · 4 comments
Assignees
@Pierre-Sassoulas
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow primer

Comments

@DanielNoord
Copy link
Collaborator

Bug description

See https://github.com/nedbat/coveragepy/commits/master/pylintrc

Three weeks ago coverage moved their pylintrc which means the Primer fails on main.

I don't have access to a laptop with a checked out repo of pylint locally but we should probably update the primer configuration.

Configuration

/

Command used

/

Pylint output

/

Expected behavior

/

Pylint version

/

OS / Environment

No response

Additional dependencies

No response
@DanielNoord DanielNoord added High priority Issue with more than 10 reactions primer labels Sep 4, 2023
@DanielNoord DanielNoord added this to the 3.0.0a8 milestone Sep 4, 2023
@Pierre-Sassoulas
Copy link
Member

I'm going to fix that. I wondered why it's failing on main and not on branches ?

@Pierre-Sassoulas Pierre-Sassoulas self-assigned this Sep 4, 2023
@DanielNoord
Copy link
Collaborator Author

I'm going to fix that. I wondered why it's failing on main and not on branches ?

Branches use the old cache and thus a commit where this doesn't occur yet.

@Pierre-Sassoulas
Copy link
Member

Ha right thank you ! The long term solution seems to be what we discussed in #8861 (comment) then

@Pierre-Sassoulas
Copy link
Member

See nedbat/coveragepy@f2aa871, pylintrc moved to pyproject.toml. I'm going to open a PR shortly.

Pierre-Sassoulas added a commit to Pierre-Sassoulas/pylint that referenced this issue Sep 4, 2023
@Pierre-Sassoulas
[primer] Fix conf following coverage's changes
247c7ff 
See nedbat/coveragepy@f2aa871

Refs pylint-dev#8998
@Pierre-Sassoulas Pierre-Sassoulas mentioned this issue Sep 4, 2023
Merged
@Pierre-Sassoulas Pierre-Sassoulas changed the title Primer is broken because coverage moved their pylintrc Primer can break unexpectedly on main because we use bleeding edge of repositories Sep 4, 2023
@Pierre-Sassoulas Pierre-Sassoulas added Maintenance Discussion or action around maintaining pylint or the dev workflow and removed High priority Issue with more than 10 reactions labels Sep 4, 2023
@Pierre-Sassoulas Pierre-Sassoulas removed this from the 3.0.0a8 milestone Sep 4, 2023
Pierre-Sassoulas added a commit to Pierre-Sassoulas/pylint that referenced this issue Sep 4, 2023
@Pierre-Sassoulas
[primer] Fix conf following coverage's changes
93bfa03 
See nedbat/coveragepy@f2aa871

Refs pylint-dev#8998
Pierre-Sassoulas added a commit that referenced this issue Sep 4, 2023
@Pierre-Sassoulas
[primer] Fix conf following coverage's changes
726cf73 
See nedbat/coveragepy@f2aa871

Refs #8998
@Pierre-Sassoulas Pierre-Sassoulas mentioned this issue Sep 28, 2023
Merged
@Pierre-Sassoulas Pierre-Sassoulas mentioned this issue Sep 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pierre-Sassoulas Pierre-Sassoulas

Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow primer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Pierre-Sassoulas @DanielNoord