Fix overzealous arguments-differ for variadics
#3001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there any progress on this? |
|
I'm going to tackle this in order to merge if it's alright for you @mattlbeck |
Pierre-Sassoulas
approved these changes
Feb 24, 2020
Pierre-Sassoulas
force-pushed
the
issue/1482-arguments-differ-variadics
branch
from
1208b5e
to
23df6bf
Compare
|
@PCManticore it seems that the problem with Appveyor being stuck can only be fixed by an administrator (Source: appveyor/ci#1848). Could you check that, please ? I don't know if this problem happens often though. Maybe simply mergeing anyway would do? |
No message is emitted if the overriding function provides positional or keyword variadics in its signature that can feasibly accept and pass on all parameters given by the overridden function. Closes pylint-dev#1482 Closes pylint-dev#1553
Pierre-Sassoulas
force-pushed
the
issue/1482-arguments-differ-variadics
branch
from
c62dcf7
to
56b3ded
Compare
|
Thanks @mattlbeck, great MR. |
|
Hello, is there any progress on this, or has the Pylint team decided to keep the current behavior? Thanks @Pierre-Sassoulas |
|
Hey, it's been merged 4 years ago, so it's available on pretty much all versions you would want to use. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps
doc/whatsnew/<current release.rst>.Description
This PR suppresses the
arguments-differmessage if the overriding function provides positional or keyword variadics in its signature that can feasibly accept and pass on all parameters given by the overridden function.Type of Changes
Related Issue
Closes #1482
Closes #1553