Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a crash in method-hidden lookup for unknown base classes #3532

Merged
merged 1 commit into from
Apr 28, 2020

Conversation

PCManticore
Copy link
Contributor

The patch replaces mro() with ancestors() as the former is not
fully capable of generating the complete linearization when
dealing with ambiguous inferences.

Close #3527

The patch replaces `mro()` with `ancestors()` as the former is not
fully capable of generating the complete linearization when
dealing with ambiguous inferences.

Close #3527
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, the code is cleaner too :)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 90.423% when pulling 100eb13 on fix-method-hidden-on-unknown-bases into 089f510 on 2.5.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 90.423% when pulling 100eb13 on fix-method-hidden-on-unknown-bases into 089f510 on 2.5.

@coveralls
Copy link

coveralls commented Apr 28, 2020

Coverage Status

Coverage increased (+0.01%) to 90.431% when pulling 100eb13 on fix-method-hidden-on-unknown-bases into 089f510 on 2.5.

@PCManticore PCManticore merged commit 90d4215 into 2.5 Apr 28, 2020
@PCManticore PCManticore deleted the fix-method-hidden-on-unknown-bases branch April 28, 2020 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants