Fix false positive superfluous-parens for the walrus operator #3697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brycepg
changed the title
brycepg
force-pushed
the
bug/issue-3383
branch
5 times, most recently
from
b972e1c
to
5b017d1
Compare
brycepg
force-pushed
the
bug/issue-3383
branch
6 times, most recently
from
c8a02c7
to
454e7e1
Compare
|
Hey @brycepg 👋 Welcome back! Thanks for the PR and for clear commits, this has been straightforward to review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps
Description
Skip over superfluous-parens checks for parenthesis wrapping the walrus operator since parenthesis can change the meaning of this operator
Type of Changes
Related Issue
Closes #3383
Closes #3278