-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add checker for empty comments #3870
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the check, and yes evidently we can't do functional tests for this one.
I made some suggestion that might not be in the spirit of the original checker. I think there is also empty comments created voluntarily to separate code part. I think it's actually better to create function/class/file/package, if you feel the need to separate different part of the code with empty comment. Your checker seems to be a way to check for this almost similar use case at the same time. Let me know what you think.
Thank for the new checker :) Could you rebase on the latest master, please ? |
@Pierre-Sassoulas I fetched the remote master and merged my branch into it. then uploaded my branch here. I wasn't sure if that is what you wanted me to do, or you wanted me to push the Master also? |
Thank you, could you rebase on it instead of merging, please ? |
@Pierre-Sassoulas I think it is fixed now. |
PR Review: refactor checker messages, test cases added: empty commit case, comments row case. unittest - pathlib replaces os.path. python3.5 fix for pathlib library use refactor `comment_ending` to `empty_comment` empty-comment test fixed (after Rebase)
I pushed again to get rid of an extra commit. There is only 1 commit for my checker now with all the fixes :) |
Thank you for the rebase and congratulation on the new checker 👍 |
Steps
Description
Added
comment_ending
plug-in for empty comments.tests/test_functional.py
folder, so I wrote a unittest instead.Type of Changes
Related Issue
None