Pruning #3872
Merged
Pruning #3872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pose as the list is simply tested with set() and then discarded.
… else. Removing this declaration, as it serves no purpose.
hippo91
reviewed
Oct 3, 2020
| # Allow stopping after the first semicolon/hash encountered, | ||
| # so that an option can be continued with the reasons | ||
| # why it is active or disabled. | ||
| OPTION_RGX = re.compile(r"\s*#.*\bpylint:\s*([^;#]+)[;#]{0,1}") |
There was a problem hiding this comment.
The re module is then useless here. It's the reason the CI doesn't success.
There was a problem hiding this comment.
@wtracy thanks for this PR. I'am ok with it as far as the CI finishes successfully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset prunes some unnecessary code (probably leftover from past refactors):
misc.pyon a value that is simply tested for existence and then discardedOPTION_RGXinconstants.py