Fix TypedDict inherit-non-class false-positive Python 3.9+ #4072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
approved these changes
Feb 6, 2021
|
The fix seems clean enough even if it's not generic aka "make astroid understand the metaclass magic". Will merge when the master branch is fixed. |
2 tasks
|
I just opened a MR in astroid to fix it there: pylint-dev/astroid#915 |
|
Well, except the tests and the changelog, I like those ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps
doc/whatsnew/<current release.rst>.Description
In Python 3.9
typing.TypedDictchanged from a class to function with some metaclass magic.This caused a
inherit-non-classerror for valid code.Source code
Python 3.8 - typing.py
Python 3.9 - typing.py
Documentation
https://docs.python.org/3/library/typing.html#typing.TypedDict
Type of Changes
Related Issue
Closes #1927