Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exempt TypedDict from too-few-public-methods check #4191

Merged
merged 1 commit into from
Mar 6, 2021
Merged

Exempt TypedDict from too-few-public-methods check #4191

merged 1 commit into from
Mar 6, 2021

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Mar 5, 2021

Steps

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Add a ChangeLog entry describing what your PR does.
  • If it's a new feature or an important bug fix, add a What's New entry in doc/whatsnew/<current release.rst>.
  • Write a good description on what the PR does.

Description

Don't check too-few-public-methods for typing.TypedDict.

Type of Changes

Type
✓ 🐛 Bug fix

Related Issue

Closes #4180

@cdce8p cdce8p mentioned this pull request Mar 5, 2021
Closed
@coveralls
Copy link

coveralls commented Mar 5, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.0007%) to 91.481% when pulling 23ac6d3 on cdce8p:typedDict-too-few-public-methods into dfb63cc on PyCQA:master.

@Pierre-Sassoulas Pierre-Sassoulas added Enhancement ✨ Improvement to a component False Positive 🦟 A message is emitted but nothing is wrong with the code labels Mar 5, 2021
@Pierre-Sassoulas Pierre-Sassoulas merged commit a7d37d2 into pylint-dev:master Mar 6, 2021
@cdce8p cdce8p deleted the typedDict-too-few-public-methods branch March 6, 2021 13:01
@cdce8p
Copy link
Member Author

cdce8p commented Mar 6, 2021

@Pierre-Sassoulas Do you what to add the 2.7.3 milestone here, as well?

@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.7.3 milestone Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Enhancement ✨ Improvement to a component False Positive 🦟 A message is emitted but nothing is wrong with the code
Projects
None yet
Milestone
2.7.3
Development

Successfully merging this pull request may close these issues.

False positive too-few-public-methods for TypedDict in Python 3.9
3 participants
@cdce8p @coveralls @Pierre-Sassoulas