Move deprecated module checker to DeprecatedMixin #4225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matusvalo
force-pushed
the
deprecated_module
branch
from
0b04b48
to
2fefb8e
Compare
matusvalo
force-pushed
the
deprecated_module
branch
2 times, most recently
from
c70f9b7
to
cfc282b
Compare
matusvalo
force-pushed
the
deprecated_module
branch
2 times, most recently
from
3eeb666
to
0873f28
Compare
matusvalo
changed the title
Pierre-Sassoulas
added
Enhancement ✨
Pierre-Sassoulas
approved these changes
Mar 17, 2021
Pierre-Sassoulas
removed
the
Needs review 🔍
|
@Pierre-Sassoulas You need to add an empty line after |
|
I swear I need a github feature to apply pre-commit auto-fix on a pull request 😄 |
|
😄 Seems like there are some trailing whitespaces now |
|
Thank you for your help @cdce8p a 5th edit would have been embarrassing, you know ? 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps
Description
This PR logic of checking the use of deprecated modules to DeprecatedMixin class.
Hence, it can be easilly reused this way.
Type of Changes
Related Issue
Closes #4086