Bug pylint 4122 #4304
Merged
Bug pylint 4122 #4304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdce8p
reviewed
Apr 6, 2021
Pierre-Sassoulas
approved these changes
Apr 7, 2021
There was a problem hiding this comment.
Nice ! We could also change the code where we added a return None somewhere unreachable because of this pylint message. (The two unreachable code here : https://lgtm.com/projects/g/PyCQA/pylint/?mode=list)
This would be some real world test too :)
cdce8p
approved these changes
Apr 7, 2021
|
@Pierre-Sassoulas The two LGTM errors you mentioned can already be fixed. I'll open a MR shortly. |
|
@cdce8p @Pierre-Sassoulas thanks a lot! |
This was referenced Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps
Description
This PR allows declaring a
never-returning-functionby just specifyingNoReturnas a return type hint.Thus the emission of
inconsistent-return-statementsmessage won't be triggered if such functions are used.Type of Changes
Related Issue
Closes #4122
Closes #4188