Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash min-max refactoring checker #4380

Merged
merged 2 commits into from
Apr 19, 2021
Merged

Fix crash min-max refactoring checker #4380

merged 2 commits into from
Apr 19, 2021

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Apr 19, 2021

Steps

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Add a ChangeLog entry describing what your PR does.
  • If it's a new feature or an important bug fix, add a What's New entry in
    doc/whatsnew/<current release.rst>.
  • Write a good description on what the PR does.

Description

Fix crash for

var = 1
if var == -1:
    var = None

Since this checker hasn't been released yet, I don't think it's necessary to write a changelog entry.

Type of Changes

Type
🐛 Bug fix

Related Issue

Closes: #4379

/CC: @Pierre-Sassoulas, @Qwiddle13, @manderj

@coveralls
Copy link

coveralls commented Apr 19, 2021

Coverage Status

Coverage increased (+0.001%) to 91.623% when pulling 3554185 on cdce8p:fix-min-max-checker into e826cec on PyCQA:master.

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job catching that !

@Pierre-Sassoulas Pierre-Sassoulas merged commit 95c05e0 into pylint-dev:master Apr 19, 2021
@cdce8p cdce8p deleted the fix-min-max-checker branch April 19, 2021 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash with new min/max refactoring checker
3 participants