-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use scm setuptools for auto-versionning #4401
Use scm setuptools for auto-versionning #4401
Conversation
de058f8
to
bdd7910
Compare
f794976
to
61dc9f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tbh I'm not too familiar with setuptools_scm
. If you think it will make things easier, go for it.
Basically it removes the need to change the version and is based on tags only. So no more change to do in the version value before and after release. |
Wating for this pr to be merged so my github ci can pass 👻 |
I don't understand @wj-Mcat ? Why would it fix your CI ? |
61dc9f6
to
536a7b0
Compare
536a7b0
to
827f20b
Compare
@cdce8p I think we can do that in 2.8 directly and we don't have to change the tags either, scm_setuptools seems to understand the tag. |
Not exactly sure what you mean here. In my experience the tag is usually just something like |
I wanted to change the tag from |
Ah, I see. I would recommend to use |
doc/release.md
Outdated
9. Do the actual release by tagging the master with `pylint-X.Y.Z` (ie `pylint-1.6.12` | ||
for example). Travis should deal with the release process once the tag is pushed with | ||
`git push origin --tags` | ||
7. Do the actual release by tagging the master with `pylint-X.Y.Z` (ie `pylint-1.6.12` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only if you what to change the tag schema
Ho okay, it's actually another problem fixed in #4407 but I'm going to release 2.8.2 just after merging this one (that just speed thing up for us maintainers) so you're still right :) |
Description
Move to scm_setuptools for easier release. Update the release doc.
Type of Changes
Related Issue
#4399 #4400