Check for <cwd> before removing first item from sys.path in modify_sys_path.
#7277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2825003760
💛 - Coveralls |
This comment has been minimized.
This comment has been minimized.
karthiknadig
force-pushed
the
issue-7231
branch
from
5086aad
to
32c69e5
Compare
DanielNoord
previously approved these changes
Aug 9, 2022
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit 32c69e5 |
Pierre-Sassoulas
previously approved these changes
Aug 9, 2022
jacobtylerwalls
dismissed stale reviews from Pierre-Sassoulas and DanielNoord
via
1f16621
jacobtylerwalls
approved these changes
Aug 9, 2022
jacobtylerwalls
changed the title
<cwd> before removing first item form sys.path in modify_sys_path.<cwd> before removing first item from sys.path in modify_sys_path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
This PR adds code to check if the item being removed from
sys.pathinmodify_sys_pathis in fact current working directory. Adds tests for the change.Closes #7231