Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make missing-return-doc respect the no-docstring-rgx option #7410

Merged
merged 2 commits into from
Sep 4, 2022
Merged

Make missing-return-doc respect the no-docstring-rgx option #7410

merged 2 commits into from
Sep 4, 2022

Conversation

DanielNoord
Copy link
Collaborator

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Add a ChangeLog entry describing what your PR does.
  • If it's a new feature, or an important bug fix, add a What's New entry in
    doc/whatsnew/<current release.rst>.
  • Write a good description on what the PR does.

Type of Changes

Type
✓ 🐛 Bug fix

Description

Closes #4743

Not sure what you were referring to in your comment but this seems to be the most logical fix. The code you were referring to is for another message.

@DanielNoord DanielNoord added Bug 🪲 Configuration Related to configuration Needs backport Needs to be cherry-picked on the current patch version by a pylint's maintainer labels Sep 4, 2022
@DanielNoord DanielNoord added this to the 2.15.1 milestone Sep 4, 2022
@github-actions

This comment has been minimized.

Sign in to view
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2988506341

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.0008%) to 95.331%
Totals Coverage Status
Change from base Build 2988311631: 0.0008%
Covered Lines: 16987
Relevant Lines: 17819
💛 - Coveralls

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2022

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit 0070622

Pierre-Sassoulas
Pierre-Sassoulas approved these changes Sep 4, 2022
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great !

@Pierre-Sassoulas Pierre-Sassoulas merged commit b00638d into pylint-dev:main Sep 4, 2022
@DanielNoord DanielNoord deleted the return-doc branch September 4, 2022 19:59
This was referenced Sep 6, 2022
Closed
Merged
@Pierre-Sassoulas Pierre-Sassoulas added Backported and removed Needs backport Needs to be cherry-picked on the current patch version by a pylint's maintainer labels Sep 6, 2022
Pierre-Sassoulas pushed a commit to Pierre-Sassoulas/pylint that referenced this pull request Sep 6, 2022
@DanielNoord @Pierre-Sassoulas
Make missing-return-doc respect the no-docstring-rgx option (p…
35007f5 
…ylint-dev#7410)
Pierre-Sassoulas pushed a commit that referenced this pull request Sep 6, 2022
@DanielNoord @Pierre-Sassoulas
Make missing-return-doc respect the no-docstring-rgx option (#…
fb3a641 
…7410)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Backported Bug 🪲 Configuration Related to configuration
Projects
None yet
Milestone
2.15.1
Development

Successfully merging this pull request may close these issues.

False positive missing-return-doc when a function is not supposed to be documented
3 participants
@DanielNoord @coveralls @Pierre-Sassoulas