Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[invalid-class-object] Fix crash when __class__ is defined with a tuple #7473

Merged
merged 3 commits into from
Sep 16, 2022
Merged

[invalid-class-object] Fix crash when __class__ is defined with a tuple #7473

merged 3 commits into from
Sep 16, 2022

Conversation

Pierre-Sassoulas
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas commented Sep 16, 2022 •
edited
Loading

Type of Changes

Type
✓ 🐛 Bug fix

Description

Closes #7467

@Pierre-Sassoulas Pierre-Sassoulas added Needs backport Needs to be cherry-picked on the current patch version by a pylint's maintainer Crash 💥 A bug that makes pylint crash labels Sep 16, 2022
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.15.3 milestone Sep 16, 2022
@Pierre-Sassoulas Pierre-Sassoulas force-pushed the fix-invalid-class-object-with-tuple branch from a565d40 to 4530626 Compare September 16, 2022 08:28
@coveralls
Copy link

coveralls commented Sep 16, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3067592274

  • 9 of 9 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 95.319%
Totals Coverage Status
Change from base Build 3066552830: 0.002%
Covered Lines: 17044
Relevant Lines: 17881
💛 - Coveralls

@Pierre-Sassoulas Pierre-Sassoulas force-pushed the fix-invalid-class-object-with-tuple branch 2 times, most recently from 2248023 to 8831477 Compare September 16, 2022 08:43
@Pierre-Sassoulas Pierre-Sassoulas changed the title Fix invalid class object with tuple [invalid-class-object] Fix crash when __class__ is defined with a tuple Sep 16, 2022
@Pierre-Sassoulas Pierre-Sassoulas changed the title [invalid-class-object] Fix crash when __class__ is defined with a tuple [invalid-class-object] Fix crash when __class__ is defined with a tuple Sep 16, 2022
@github-actions

This comment has been minimized.

Sign in to view
jacobtylerwalls
jacobtylerwalls previously approved these changes Sep 16, 2022
View reviewed changes
doc/whatsnew/fragments/7467.bugfix Outdated Show resolved Hide resolved
pylint/checkers/classes/class_checker.py Outdated Show resolved Hide resolved
pylint/checkers/classes/class_checker.py Show resolved Hide resolved
@Pierre-Sassoulas Pierre-Sassoulas force-pushed the fix-invalid-class-object-with-tuple branch from 940be6c to 77f97bd Compare September 16, 2022 11:37
jacobtylerwalls
jacobtylerwalls reviewed Sep 16, 2022
View reviewed changes
tests/functional/i/invalid/invalid_class_object.txt Outdated
@@ -1,2 +1,5 @@
invalid-class-object:17:0:17:11::Invalid __class__ object:UNDEFINED
invalid-class-object:18:0:18:11::Invalid __class__ object:UNDEFINED
invalid-class-object:20:0:20:11::Invalid assignement to '__class__'. Should be a class definition but got a 'Instance':INFERENCE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These have to be updated.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦

@Pierre-Sassoulas Pierre-Sassoulas force-pushed the fix-invalid-class-object-with-tuple branch from 77f97bd to 98ef493 Compare September 16, 2022 11:44
@github-actions
Copy link
Contributor

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit 98ef493

@Pierre-Sassoulas Pierre-Sassoulas merged commit b47aa30 into pylint-dev:main Sep 16, 2022
@Pierre-Sassoulas Pierre-Sassoulas deleted the fix-invalid-class-object-with-tuple branch September 16, 2022 14:00
@Pierre-Sassoulas Pierre-Sassoulas added Backported and removed Needs backport Needs to be cherry-picked on the current patch version by a pylint's maintainer labels Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobtylerwalls jacobtylerwalls jacobtylerwalls approved these changes

Assignees
No one assigned
Labels
Backported Crash 💥 A bug that makes pylint crash
Projects
None yet
Milestone
2.15.3
Development

Successfully merging this pull request may close these issues.

Even after #7429 merged, a crash AttributeError: 'ClassDef' object has no attribute 'value'
3 participants
@Pierre-Sassoulas @coveralls @jacobtylerwalls