[Backport maintenance/2.17.x] Ignore quantifiers when splitting comma-separated regexes (#8898) #8901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#8898) Do not split on commas if they are between braces, since that indicates a quantifier. Also added a protection for slow implementations since existing workarounds may result in long strings of chained regular expressions. Adjust existing test for invalid regex to be truly invalid Co-authored-by: lihu <[email protected]> (cherry picked from commit d28def9)
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## maintenance/2.17.x #8901 +/- ##
======================================================
- Coverage 95.57% 95.57% -0.01%
======================================================
Files 178 178
Lines 18844 18862 +18
======================================================
+ Hits 18010 18027 +17
- Misses 834 835 +1
|
mbyrnepr2
approved these changes
Jul 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #8898 from d28def9.